Skip to content

[PWGHF] IWYU. Minor fixes. Remove mass aliases. #14498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
vkucera wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

[PWGHF] IWYU. Minor fixes. Remove mass aliases. #14498

vkucera wants to merge 10 commits into from
+261 −277

Conversation

@vkucera
Copy link
Collaborator

@vkucera vkucera commented Jan 15, 2026 •
edited
Loading

  • IWYU.
  • Fix include format.
  • Fix missing braces.
  • Fix missing initialisations.
  • Fix const members.
  • Replace mass aliases with constants.
  • Replace reinterpret_cast with dynamic_cast.
  • Rename toMicrometers -> CentiToMicro.
  • Comment unresolved issues.
    • PWGHF/HFC/Tasks/taskFlow.cxx
    • PWGHF/HFL/Tasks/taskElectronWeakBoson.cxx

@github-actions github-actions bot added the pwghf PWG-HF label Jan 15, 2026
@github-actions github-actions bot changed the title IWYU. Minor fixes. Remove mass aliases. [PWGHF] IWYU. Minor fixes. Remove mass aliases. Jan 15, 2026
@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

O2 linter results: ❌ 72 errors, ⚠️ 19 warnings, 🔕 33 disabled

@vkucera
Copy link
Collaborator Author

vkucera commented Jan 16, 2026

Waiting for #14358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild will be requested when the pull request is marked ready for review alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar will be requested when the pull request is marked ready for review fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa will be requested when the pull request is marked ready for review fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 will be requested when the pull request is marked ready for review fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin will be requested when the pull request is marked ready for review mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli will be requested when the pull request is marked ready for review mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms will be requested when the pull request is marked ready for review deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid will be requested when the pull request is marked ready for review NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 will be requested when the pull request is marked ready for review hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk will be requested when the pull request is marked ready for review jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano will be requested when the pull request is marked ready for review apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy will be requested when the pull request is marked ready for review zhangbiao-phy is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel will be requested when the pull request is marked ready for review gluparel is a code owner

@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano will be requested when the pull request is marked ready for review stefanopolitano is a code owner

@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 will be requested when the pull request is marked ready for review singhra1994 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vkucera